Forum Moderators: phranque

Message Too Old, No Replies

Cleaning up a predecessor's Code

--site created in GoLive w/ a LOT of includes...

         

mcjohnson

12:20 pm on Apr 26, 2007 (gmt 0)

10+ Year Member



This may or may not be the proper forum, so here goes.

I was hired to bring a site up to date of a moderately large midwestern company. Their prior web designer created their site using Adobe Golive, and, among other things, uses at least two includes: i.e. <?php include("incl_pagetop_1.html")?>

Question 1: The interesting thing is, the header include and the FOOTER include DOCTYPES. Which means when you pull up the page and look at the source, you see a significant skew - doctype at the top, another one 1/2 down, another further down even yet.

What gives? I realize if you want to validate the individual include you need a doctype. But I assume it's safe to remove same from the includes now? I just think it looks sloppy and I really don't want to put my rubber stamp on a site with sloppy code.

Question #2: Although the PAGE title is unique, the pages are inheriting the meta data via an include as well. Does this not erode the rankings? I thought that unique and well written description tags for each page would be desirable.

Any comments would be appreciated.

jatar_k

4:38 pm on Apr 27, 2007 (gmt 0)

WebmasterWorld Administrator 10+ Year Member



my guess is the doctype was added to each include file because the person before you made each in a WYSIWYG editor. I would think the extra ones can be removed, I can't think of any reason they couldn't.

>> Does this not erode the rankings?

I would say no, if you had the time to add descriptions for each there may be a small advantgae to that but I don't see any great disadvantage to having them the same.

Most of the time I have an include for them with an option to overide those vars so that if I would like to do them for specific pages I can. The advantage is no longer great enough that I feel using all that time to write unique ones for every page on the site is a anything but a waste.

pageoneresults

4:42 pm on Apr 27, 2007 (gmt 0)

WebmasterWorld Senior Member 10+ Year Member Top Contributors Of The Month



Question 1: I realize if you want to validate the individual include you need a doctype. But I assume it's safe to remove same from the includes now?

Depends on the type of include. In this case, you normally wouldn't validate the include itself. You'd validate the assembled page where the include was rendered.

What else is in your include code besides a DOCTYPE?

Question #2: Although the PAGE title is unique, the pages are inheriting the meta data via an include as well. Does this not erode the rankings? I thought that unique and well written description tags for each page would be desirable.

They are desirable and suggested. There have been reported cases of pages falling prey to some sort of filter if their metadata was duplicated across pages.

jatar_k

8:16 pm on Apr 27, 2007 (gmt 0)

WebmasterWorld Administrator 10+ Year Member



>> desirable and suggested

to be honest, I'm not totally sure what I was talking about there

just listen to pageone, he's right, thanks for correcting me

here's a thread, one of many
[webmasterworld.com...]