1. Home
  2. Forums Index
  3. Server Side / Perl Server Side CGI Scripting 12:42 am May 21, 2026

Forum Moderators: coopster & phranque

Message Too Old, No Replies

Perl File Upload Error - No such file or directory

Perl Error

         

Rockchick

8:11 am on Jul 11, 2010 (gmt 0)

10+ Year Member



Hi guys,

My first time here in a web forum, and you all seem like a helpful bunch. Always good to find a friendly place where I can lend a hand or get a helping hand :)

Hoping someone can help.... when I hit submit on my link, the error says:
No such file or directory at test.cgi line 31


Here is line 31 of test.cgi:
open ( UPLOADFILE, ">$upload_dir/$filename" ) or die "$!";


Now, here is the html code: 
 <form action="/cgi-bin/test.cgi" method="post" 
enctype="multipart/form-data">
  <p>File: <input type="file" name="file_upload" /></p>
  <p>Email Address: <input type="text" name="email_address" /></p>
  <p><input type="submit" name="Submit" value="Submit Form" /></p>
 </form>


And here is the code from the test.cgi file: 
#!/usr/bin/perl -wT 
use strict; 
use CGI; 
use CGI::Carp qw ( fatalsToBrowser ); 
use File::Basename; 
$CGI::POST_MAX = 1024 * 5000000;
my $safe_filename_characters = "a-zA-Z0-9_.-"; 
my $upload_dir = "/uploads"; 
my $query = new CGI; 
my $filename = $query->param("photo"); 
my $email_address = $query->param("email_address"); 
if ( !$filename ) 
{ 
 print $query->header ( ); 
 print "There was a problem uploading your photo (try a smaller file)."; 
 exit; 
} 
my ( $name, $path, $extension ) = fileparse ( $filename, '\..*' ); 
$filename = $name . $extension; 
$filename =~ tr/ /_/; 
$filename =~ s/[^$safe_filename_characters]//g; 
if ( $filename =~ /^([$safe_filename_characters]+)$/ ) 
{ 
 $filename = $1; 
} 
else 
{ 
 die "Filename contains invalid characters"; 
} 
my $upload_filehandle = $query->upload("photo"); 
open ( UPLOADFILE, ">$upload_dir/$filename" ) or die "$!"; 
binmode UPLOADFILE; 
while ( <$upload_filehandle> ) 
{ 
 print UPLOADFILE; 
} 
close UPLOADFILE; 
print $query->header ( ); 
print <<END_HTML; 
<html>
 <head> 
 <title>Thanks!</title> 
 <style type="text/css"> 
  img {border: none;} 
 </style> 
 </head> 
 <body> 
 <p>Thanks for uploading your photo!</p> 
 <p>Your email address: $email_address</p> 
 <p>Your photo:</p> 
 <p><img src="/upload/$filename" alt="Photo" /></p> 
 </body> 
</html> 
END_HTML
;


Once I get this working, I will be adapting it so that my clients can upload any kind of file to me (it's not going to be just photo's).

I hope someone can help, this has driven me nuts and please be gentle - I'm still rather new at all this! lol

Cheers guys,
From way down under in NEW ZEALAND :)
Rockchick

phranque

8:34 am on Jul 11, 2010 (gmt 0)

WebmasterWorld Administrator 10+ Year Member Top Contributors Of The Month



welcome to WebmasterWorld [webmasterworld.com], Rockchick!

i see a couple of possible problems:
my $upload_dir = "/uploads";

the open is going to look for the "uploads" directory at the root of the filesystem, not the document root directory.

my $filename = $query->param("photo");

i don't see a parameter named "photo" in your form.

Rockchick

8:42 am on Jul 11, 2010 (gmt 0)

10+ Year Member



Thanks Phranque for the warm welcome! :)

Oookay... well yep, those fixed that problem! Thank you! I knew it would be something simple that I had just not seen!

But... one more problem... now when I got try the script, I Browse to a pic (and it's only 22KB, but I get the error:
There was a problem uploading your photo (try a smaller file).


Do you reckon it's ok to take this line out: 
$CGI::POST_MAX = 1024 * 5000000;


Thanks again :)

phranque

11:03 am on Jul 11, 2010 (gmt 0)

WebmasterWorld Administrator 10+ Year Member Top Contributors Of The Month



i would suggest:
my $filename = $query->param("file_upload"); if ( !$filename ){ print $query->header( ); print $query->cgi_error(); print "There was a problem uploading your photo (try a smaller file)."; exit; }

Rockchick

8:19 pm on Jul 11, 2010 (gmt 0)

10+ Year Member



Thanks for the suggestion phranque, I tried it but comes up with this error:

Global symbol "$email_address" requires explicit package name at test.cgi line 38.
Execution of test.cgi aborted due to compilation errors.


I think all variables need a package name.

Hmmm this isn't going to be as easy as I thought.... any idea's?

Thank you :)

chorny

11:05 pm on Jul 11, 2010 (gmt 0)

10+ Year Member




I think all variables need a package name.

They need to be declared with "my".


Hmmm this isn't going to be as easy as I thought.... any ideas?

Please repost your final code with all changes.

phranque

11:18 pm on Jul 11, 2010 (gmt 0)

WebmasterWorld Administrator 10+ Year Member Top Contributors Of The Month



do you still have this line of code in your script?
my $email_address = $query->param("email_address");

Rockchick

11:26 pm on Jul 11, 2010 (gmt 0)

10+ Year Member



Thanks chorny :)

They need to be declared with "my".

Yep I have done that... but when I took this line out: 
my $email_address = $query->param("email_address");

I got the error in my post above. So have put it back in.

So... at the moment it stands as this:
on my html doc: 
 <form action="/cgi-bin/test.cgi" method="post" 
enctype="multipart/form-data">
 <p>File: <input type="file" name="file_upload" /></p>
 <p>Email Address: <input type="text" name="email_address" /></p>
 <p><input type="submit" name="Submit" value="Submit Form" /></p>
 </form>


and the test.cgi file: 

#!/usr/bin/perl -wT 
use strict; 
use CGI; 
use CGI::Carp qw ( fatalsToBrowser ); 
use File::Basename; 
$CGI::POST_MAX = 1024 * 5000;
my $safe_filename_characters = "a-zA-Z0-9_.-"; 
my $upload_dir = "http://www.example.com/uploads"; 
my $query = new CGI; 
my $filename = $query->param("file_upload");
my $email_address = $query->param("email_address");
if ( !$filename )
{
print $query->header ( );
print "There was a problem uploading your photo (try a smaller file).";
exit;
} 
my ( $name, $path, $extension ) = fileparse ( $filename, '\..*' ); 
$filename = $name . $extension; 
$filename =~ tr/ /_/; 
$filename =~ s/[^$safe_filename_characters]//g; 
if ( $filename =~ /^([$safe_filename_characters]+)$/ ) 
{ 
 $filename = $1; 
} 
else 
{ 
 die "Filename contains invalid characters"; 
} 
my $upload_filehandle = $query->upload("photo"); 
open ( UPLOADFILE, ">$upload_dir/$filename" ) or die "$!"; 
binmode UPLOADFILE; 
while ( <$upload_filehandle> ) 
{ 
 print UPLOADFILE; 
} 
close UPLOADFILE; 
print $query->redirect ( "http://www.example.co.nz/success.html" );


And finally, I'm still getting the error:
There was a problem uploading your photo (try a smaller file).


There's a problem uploading the file somewhere... I have set the permissions on the .cgi file at 755 and the uploads folder to 777. So they are all good.

[edited by: phranque at 3:02 am (utc) on Jul 12, 2010]
[edit reason] exemplified domains [/edit]

Rockchick

11:33 pm on Jul 11, 2010 (gmt 0)

10+ Year Member



phranque:
do you still have this line of code in your script?
my $email_address = $query->param("email_address");


When I took that line out phranque, I got the error:
Global symbol "$email_address" requires explicit package name at test.cgi line 38.
Execution of test.cgi aborted due to compilation errors.


so... for now, have put it back in.

Rockchick

12:34 am on Jul 12, 2010 (gmt 0)

10+ Year Member



Ok I got it working! The $upload_dir was wrong.... argh! I knew it would be something staring me in the face!

Thank you all for your help :)

One last question, if you don't mind... you know how I have email address on the form? Well.... where does that parameter go? I mean, I will get the file that has been uploaded by the person, but where will I find their email address?

phranque

2:25 am on Jul 12, 2010 (gmt 0)

WebmasterWorld Administrator 10+ Year Member Top Contributors Of The Month



the value entered by the visitor in the "email_address" form field is the value returned by $query->param("email_address").
is that what you are asking?

Rockchick

6:55 am on Jul 12, 2010 (gmt 0)

10+ Year Member



I got it all up and working - so when I browse to a file, enter my email and hit submit - it all works great. Then I check on my server and the file is there. But I'm wondering where I find the email that I submitted...

(for example if my client uploads a file, and enters their email - it would be helpful if I can then see that and identify who sent what... rather than just have all these uploads in there and not knowing what belongs to who)

phranque

7:26 am on Jul 12, 2010 (gmt 0)

WebmasterWorld Administrator 10+ Year Member Top Contributors Of The Month



i think i misunderstood your question about the where the email address was.

2 options for associating the email address to the uploaded file:

- you can use some type of database to store the relationship between the email and the file; this could even be implemented with a flat file solution.

- you could use the email address in your file naming convention. (for example, such as mailbox@example.com_filename.jpg)
note that you can rename the image file without the email address before serving it if necessary.

Rockchick

8:45 am on Jul 12, 2010 (gmt 0)

10+ Year Member



Oookay sounds like it's way above my head :(
That's ok, I will do some research on it... Google is my best friend! haha
Thanks for all your help :)
 

Join The Conversation

Moderators and Top Contributors

Hot Threads This Week

  1. Home
  2. Forums Index
  3. Server Side / Perl Server Side CGI Scripting 12:42 am May 21, 2026